Skip to content

Remove unused export: CopilotModelValidationResult#5029

Merged
lpcox merged 2 commits into
mainfrom
copilot/remove-unused-export-copilotmodelvalidationresult
Jun 15, 2026
Merged

Remove unused export: CopilotModelValidationResult#5029
lpcox merged 2 commits into
mainfrom
copilot/remove-unused-export-copilotmodelvalidationresult

Conversation

Copilot AI commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CopilotModelValidationResult was exported from src/copilot-model.ts but never imported anywhere else in the codebase, unnecessarily expanding the public API surface.

Changes

  • src/copilot-model.ts: Drop export from CopilotModelValidationResult type alias — it remains usable within the module as the return type of validateCopilotModel, just no longer part of the public contract.
-export type CopilotModelValidationResult =
+type CopilotModelValidationResult =
   | CopilotModelValidationSuccess
   | CopilotModelValidationFailure;

Copilot AI changed the title [WIP] Remove unused export CopilotModelValidationResult Remove unused export: CopilotModelValidationResult Jun 15, 2026
Copilot finished work on behalf of lpcox June 15, 2026 13:50
Copilot AI requested a review from lpcox June 15, 2026 13:50
@lpcox lpcox marked this pull request as ready for review June 15, 2026 14:35
Copilot AI review requested due to automatic review settings June 15, 2026 14:35
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 96.86% 96.90% 📈 +0.04%
Statements 96.73% 96.77% 📈 +0.04%
Functions 98.81% 98.81% ➡️ +0.00%
Branches 91.24% 91.27% 📈 +0.03%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/workdir-setup.ts 92.6% → 94.4% (+1.85%) 92.6% → 94.4% (+1.85%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the public TypeScript API surface by making CopilotModelValidationResult a module-private type alias in src/copilot-model.ts, while still using it internally as the return type of validateCopilotModel.

Changes:

  • Remove the export modifier from CopilotModelValidationResult so it is no longer importable by external modules.
  • Keep validateCopilotModel()’s return type unchanged within the module.
Show a summary per file
File Description
src/copilot-model.ts Makes CopilotModelValidationResult non-exported to avoid exposing an unused type as part of the package’s public API.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🔬 Smoke Test: Copilot PAT Auth — PASS

Test Result
GitHub MCP connectivity ✅
GitHub.com HTTP ✅ 200
File write/read ⚠️ template vars unsubstituted

PR: "Remove unused export: CopilotModelValidationResult"
Author: @Copilot | Assignees: @lpcox, @Copilot
Auth mode: PAT (COPILOT_GITHUB_TOKEN)

Overall: PASS (verifiable tests passed; file test skipped due to unsubstituted template vars in workflow)

🔑 PAT report filed by Smoke Copilot PAT

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Result
GitHub MCP connectivity ✅ PASS
GitHub.com HTTP connectivity ⚠️ N/A (template vars unsubstituted)
File write/read ⚠️ N/A (template vars unsubstituted)

PR: "Remove unused export: CopilotModelValidationResult" — @Copilot (assignees: @lpcox, @Copilot)

Overall: PASS (MCP verified; pre-step data unavailable due to unsubstituted template variables)

📰 BREAKING: Report filed by Smoke Copilot

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@Copilot Smoke test results:

  • github-list_pull_requests: ✅
  • GitHub.com connectivity: ✅
  • File I/O in sandbox: ✅
  • Direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw): ✅

Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Remove unused export: CopilotModelValidationResult
Deduplicate Copilot bearer-prefix stripping in api-proxy
refactor(api-proxy): deduplicate guard enforcement between HTTP and WebSocket paths, fix 3 missing WebSocket guards
✅ GitHub reads
✅ Playwright
✅ File write
✅ Discussion comment
✅ Build
Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🧪 Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ No
Node.js v24.16.0 v22.22.3 ❌ No
Go go1.22.12 go1.22.12 ✅ Yes

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Smoke Test Results

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

✅ Smoke Test: Copilot BYOK (Direct Mode) - PASS

  • ✅ GitHub MCP connectivity
  • ✅ github.com reachable (HTTP 200)
  • ✅ File write/read test
  • ✅ BYOK inference operational (agent → api-proxy → api.githubcopilot.com)

Running in direct BYOK mode via COPILOT_PROVIDER_API_KEY with api-proxy sidecar authentication.

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Smoke Test Results: FAIL ❌

Check Result
Redis PING ❌ Timed out (no response)
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Timed out (no response)

host.docker.internal services unreachable — all 3 checks failed.

🔌 Service connectivity validated by Smoke Services

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia ✅ 1/1 passed ✅ PASS
Bun hono ✅ 1/1 passed ✅ PASS
C++ fmt ✅ N/A ✅ PASS
C++ json ✅ N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world ✅ N/A ✅ PASS
.NET json-parse ✅ N/A ✅ PASS
Go color ✅ 1/1 passed ✅ PASS
Go env ✅ 1/1 passed ✅ PASS
Go uuid ✅ 1/1 passed ✅ PASS
Java gson ✅ 1/1 passed ✅ PASS
Java caffeine ✅ 1/1 passed ✅ PASS
Node.js clsx ✅ all passed ✅ PASS
Node.js execa ✅ all passed ✅ PASS
Node.js p-limit ✅ all passed ✅ PASS
Rust fd ✅ 1/1 passed ✅ PASS
Rust zoxide ✅ 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5029 · ◷

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@Copilot @lpcox

  • Remove unused export: CopilotModelValidationResult
  1. MCP PR listing: ✅
  2. GitHub.com connectivity: ✅
  3. File write/read: ✅
  4. BYOK inference: ✅
    Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
    Overall status: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

@github-actions github-actions Bot mentioned this pull request Jun 15, 2026
Closed
@lpcox lpcox merged commit c101c34 into main Jun 15, 2026
77 of 83 checks passed
@lpcox lpcox deleted the copilot/remove-unused-export-copilotmodelvalidationresult branch June 15, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lpcox lpcox Awaiting requested review from lpcox

Assignees

@lpcox lpcox

Copilot code review Copilot

Labels

build-test smoke-codex smoke-copilot smoke-copilot-byok smoke-copilot-byok-aoai-apikey smoke-copilot-pat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lpcox